[Spice-devel] DisplayChannel, Stream and StreamAgent redefinitions

[Frediano Ziglio]

> 
> The commit below causes compilation errors on RHEL 6.8 :-(
> (gcc 4.4.7)
> 
>   CC     red-worker.lo
> In file included from display-channel.h:43,
>                  from red-worker.c:47:
> stream.h:46: error: redefinition of typedef 'DisplayChannel'
> dcc.h:44: note: previous declaration of 'DisplayChannel' was here
> stream.h:48: error: redefinition of typedef 'Stream'
> dcc.h:45: note: previous declaration of 'Stream' was here
> stream.h:89: error: redefinition of typedef 'StreamAgent'
> dcc.h:46: note: previous declaration of 'StreamAgent' was here
> 
> 
> 
> commit a84a433e0840d0eb65d4eb5c51f6cdde94a2c210
> Author: Jonathon Jongsma <jjongsma at redhat.com>
> Date:   Fri Aug 5 14:02:29 2016 -0500
> 
>     Limit direct access to DisplayChannelClient
>     
>     Add a few more methods and accessors so that other files don't need to
>     manipulate the struct members directly. Move the struct definition to a
>     private header which only the dcc-* files will include.
>     
>     Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
>     Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
>     Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
> 
> Presumably that's temporary and can pretty much only be endured?
> 

There was some discussion time ago about this problem.
Many solutions but no common consensus.
Temporary... well, surely when RHEL 6.x support will be over this
will be fixed.
In theory when we'll have more encapsulation this will be solved
by itself.

Frediano