[Spice-devel] [PATCH 01/11] Move RedChannelClient to separate file

[Jonathon Jongsma]

On Fri, 2016-08-12 at 03:55 -0400, Frediano Ziglio wrote:
> > 
> > 
> > Reduce direct access to RedChannelClient, and get ready to convert
> > to
> > GObject.
> 
> This patch should be mechanical but I'm having some problems
> reviewing.
> I have to do some magic about new files, the diff is terrible, not
> clear if we miss some other patches in the meantime.
> The most scary thing however is that red-channel-client-private.h is
> included everywhere. It's not private at all!
> 


working on splitting this and the next commit up into a bit more
manageable pieces. It's difficult for me to review as well, and I
apparently wrote it :/



> Frediano
> 
> > 
> > ---
> >  server/Makefile.am                  |    3 +
> >  server/cursor-channel.c             |    2 +
> >  server/dcc-private.h                |    1 +
> >  server/dcc.h                        |    2 +-
> >  server/display-channel.c            |    3 +-
> >  server/inputs-channel-client.c      |    1 +
> >  server/inputs-channel.c             |   15 +-
> >  server/main-channel-client.c        |   23 +-
> >  server/main-channel.c               |   39 +-
> >  server/red-channel-client-private.h |   78 ++
> >  server/red-channel-client.c         | 1626
> > +++++++++++++++++++++++++++++++
> >  server/red-channel-client.h         |  177 ++++
> >  server/red-channel.c                | 1835
> >  +++--------------------------------
> >  server/red-channel.h                |  185 +---
> >  server/red-qxl.c                    |   24 +-
> >  server/red-worker.c                 |    3 +-
> >  server/reds.c                       |   22 +-
> >  server/smartcard.c                  |    2 +-
> >  server/sound.c                      |    8 +-
> >  server/spicevmc.c                   |   31 +-
> >  server/stream.c                     |   11 +-
> >  21 files changed, 2146 insertions(+), 1945 deletions(-)
> >  create mode 100644 server/red-channel-client-private.h
> >  create mode 100644 server/red-channel-client.c
> >  create mode 100644 server/red-channel-client.h
> > 
> > diff --git a/server/Makefile.am b/server/Makefile.am
> > index 24e6e21..a249046 100644
> > --- a/server/Makefile.am
> > +++ b/server/Makefile.am
> > @@ -95,6 +95,9 @@ libserver_la_SOURCES =				
> > \
> >  	mjpeg-encoder.c				\
> >  	red-channel.c				\
> >  	red-channel.h				\
> > +	red-channel-client.c			\
> > +	red-channel-client.h			\
> > +	red-channel-client-private.h		\
> >  	red-common.h				\
> >  	dispatcher.c				\
> >  	dispatcher.h				\
> > diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> > index dac929a..83ce61b 100644
> > --- a/server/cursor-channel.c
> > +++ b/server/cursor-channel.c
> > @@ -21,7 +21,9 @@
> >  
> >  #include <glib.h>
> >  #include <common/generated_server_marshallers.h>
> > +
> >  #include "cursor-channel.h"
> > +#include "red-channel-client-private.h"
> >  #include "cache-item.h"
> >  
> 
> ....