[Spice-devel] [PATCH spice-gtk 1/2] build-sys: require recent pkg-config

[Marc-André Lureau]

Hi

----- Original Message -----
> Hi,
> 
> On Mon, Aug 22, 2016 at 01:57:12PM -0400, Marc-André Lureau wrote:
> > Hi
> > 
> > ----- Original Message -----
> > > Hi,
> > > 
> > > On Fri, Aug 19, 2016 at 09:35:09PM +0400, marcandre.lureau at redhat.com
> > > wrote:
> > > > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > > > 
> > > > So we can drop the AC_SUBST for _CFLAGS & _LIBS variable (since 0.24
> > > > but there is no clean way to check that before PKG_PREREQ in 0.29,
> > > > released last year)
> > > 
> > > weird:
> > > 
> > > spice-gtk $ ./autogen.sh --prefix /home/vtosodec/work/jhbuild/dev
> > > --enable-polkit=no --enable-static
> > > autoreconf: Entering directory `.'
> > > autoreconf: configure.ac: not using Gettext
> > > autoreconf: running: aclocal -I
> > > /home/vtosodec/work/jhbuild/dev/share/aclocal
> > > --force -I m4
> > > configure.ac:15: error: must install pkg-config 0.29 or later before
> > > running
> > > autoconf/autogen
> > > configure.ac:15: the top level
> > > autom4te: /usr/bin/m4 failed with exit status: 1
> > > aclocal: error: echo failed with exit status: 1
> > > autoreconf: aclocal failed with exit status: 1
> > > 
> > > spice-gtk $ pkg-config --version
> > > 0.29
> > 
> > Hmm, what about your jhbuild environment ?
> 
> Yes, on my jhbuild shell it fails but not on my system shell :)

jhbuild seems to bootstrap with 0.28, but it should rely on system pkg-config by default iirc.

Since jhbuild uses released tarballs, I think we should be fine, I'll commit then.

thanks