[Spice-devel] [PATCH spice-gtk 1/2] build-sys: require recent pkg-config

[Christophe Fergeau]

Another option would be to ship pkg.m4 from pkg-config 0.29 in
spice-gtk/m4/, though I don't understand how AC_SUBST was made unneeded,
so maybe that's not enough (?)

Christophe

On Tue, Aug 30, 2016 at 12:52:43PM +0200, Christophe Fergeau wrote:
> On Fri, Aug 19, 2016 at 09:35:09PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> > 
> > So we can drop the AC_SUBST for _CFLAGS & _LIBS variable (since 0.24
> > but there is no clean way to check that before PKG_PREREQ in 0.29,
> > released last year)
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  configure.ac | 26 ++++----------------------
> >  1 file changed, 4 insertions(+), 22 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 9b2351d..1e27202 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -12,6 +12,8 @@ AM_INIT_AUTOMAKE([foreign dist-bzip2 -Wall -Werror -Wno-portability])
> >  m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
> >  LT_INIT([disable-static win32-dll])
> >  AM_MAINTAINER_MODE
> > +m4_ifndef([PKG_PREREQ],
> > +        [m4_fatal([must install pkg-config 0.29 or later before running autoconf/autogen])])
> 
> NACK to that bit, as Victor's testing showed, it's not that widespread
> yet. Maybe something PKG_PREREQ-like can be built using $(pkg-config
> --version) and m4_version_compare(), alternatively, we could just assume 0.24 is always present.
> Or just revert this patch.
> 
> Christophe


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160830/c607250e/attachment-0001.sig>