[Spice-devel] [PATCH spice-gtk 1/2] build-sys: require recent pkg-config

[Christophe Fergeau]

On Tue, Aug 30, 2016 at 11:45:06AM +0000, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Aug 30, 2016 at 3:24 PM Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > Another option would be to ship pkg.m4 from pkg-config 0.29 in
> > spice-gtk/m4/, though I don't understand how AC_SUBST was made unneeded,
> > so maybe that's not enough (?)
> >
> 
> m4 should be enough, however it seems that AC_SUBST of _CFLAGS & _LIBS  has
> been there forever. But it was changed in
> https://cgit.freedesktop.org/pkg-config/commit/?id=b1584b5aaf9ce396e61599caff2b5e15f01daf91
> 
> Now I don't get what autofoo magic put them in the subst list, but it works.
> 
> My comment was based on
> https://autotools.io/pkgconfig/pkg_check_modules.html doc, which is usually
> a solid reference, but here I don't know what backs the 0.24...
> 
> So, I think we could simply remove the prereq.

Works for me!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160830/3ab5067d/attachment.sig>