[Spice-devel] [spice-gtk v2 2/2] channel-usbredir: prevent crash when calling without host

Christophe Fergeau cfergeau at redhat.com
Thu Dec 1 12:33:56 UTC 2016


On Wed, Nov 30, 2016 at 06:57:12PM +0100, Victor Toso wrote:
> Hi,
> 
> On Wed, Nov 30, 2016 at 06:45:45PM +0100, Pavel Grunt wrote:
> > imho this should be in usbredir
> >
> > It is not nice when library crashes your program
> 
> I don't disagree. Libraries should use guards accordingly.
> 
> But it doesn't make this correct. We should have initialized
> usbredirhost before calling this API, making this a spice-gtk mistake.
> 
> Either way is fine to me... maybe both :)

I guess an usbredir patch adding such guards to public entry points
would be accepted.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161201/f95177d6/attachment-0001.sig>


More information about the Spice-devel mailing list