[Spice-devel] [spice-gtk v1] channel-main: demote log level from warning to debug

[Victor Toso]

On Thu, Dec 01, 2016 at 11:37:32AM +0100, Christophe Fergeau wrote:
> On Wed, Nov 30, 2016 at 06:50:39PM +0100, Victor Toso wrote:
> > From: Victor Toso <me at victortoso.com>
> >
> > Failing to get playback or record volume async on startup is very
> > common making this warning too worrisome for users.
> >
>
> Looked quickly at the code, and this seems to be getting the volume info
> from pulseaudio. What is special at startup that makes this not work?

As mentioned in the commit log below:

> > If the audio back-end does not cache the last volume used or if this
> > is the first time the application is launched, this message will be
> > seen.

With pulseaudio back-end, the playback/record volume is cached in user
file with the application name as reference. The volume info should
fail:

1-) For playback, in the first time a spice client is launched
2-) For record, always till the first it is used and, furthermore,
    cached.

For gstreamer back-end, even with pulseaudio src/sink, it might not fail
but it will be wrong, see:
https://bugzilla.gnome.org/show_bug.cgi?id=766020

> >
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  src/channel-main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/channel-main.c b/src/channel-main.c
> > index 72ca712..e632c8e 100644
> > --- a/src/channel-main.c
> > +++ b/src/channel-main.c
> > @@ -1171,7 +1171,7 @@ static void audio_playback_volume_info_cb(GObject *object, GAsyncResult *res, gp
> >                                                        &volume, &error);
> >      if (ret == FALSE || volume == NULL || nchannels == 0) {
> >          if (error != NULL) {
> > -            g_warning("Failed to get playback async volume info: %s", error->message);
> > +            spice_debug("Failed to get playback async volume info: %s", error->message);
> >              g_error_free(error);
> >          } else {
> >              SPICE_DEBUG("Failed to get playback async volume info");
> > @@ -1227,7 +1227,7 @@ static void audio_record_volume_info_cb(GObject *object, GAsyncResult *res, gpoi
> >      ret = spice_audio_get_record_volume_info_finish(audio, res, &mute, &nchannels, &volume, &error);
> >      if (ret == FALSE || volume == NULL || nchannels == 0) {
> >          if (error != NULL) {
> > -            g_warning("Failed to get record async volume info: %s", error->message);
> > +            spice_debug("Failed to get record async volume info: %s", error->message);
> >              g_error_free(error);
> >          } else {
> >              SPICE_DEBUG("Failed to get record async volume info");
> > -- 
> > 2.9.3
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161201/dae6920b/attachment.sig>