[Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

Frediano Ziglio fziglio at redhat.com
Mon Dec 5 14:16:45 UTC 2016


> 
> On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote:
> > On Thu, 2016-12-01 at 11:24 +0000, Frediano Ziglio wrote:
> > > This code is the same inside __new_channel but will set the
> > > RedsStream from RedChannel.
> > 
> > Shouldn't this code be removed from __new_channel() then?
> 
> I agree that this would make things it more obvious what's going on by
> looking at the diff. Unless __new_channel is still used for now, and
> removing this breaks things.
> 
> Christophe
> 
> 

Should I merge into the GObject patch then?

Frediano


More information about the Spice-devel mailing list