[Spice-devel] [PATCH spice-common] Marshaller: rename _add_ref() to _add_by_ref()

[Christophe Fergeau]

On Mon, Dec 05, 2016 at 04:19:04PM -0600, Jonathon Jongsma wrote:
> The spice_marshaller_add_ref() family of functions is confusing since it
> sounds like you're incrementing a reference on the marshaller. What it
> is actually doing is adding a data buffer to the marshaller by reference
> rather than by value. Changing the function names to _add_by_ref() makes
> this clearer.
> 
> The old functions are deprecated and are simply inline functions that
> call the new functions.

Do we have to keep the old ones?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161206/18d3ba9b/attachment.sig>