[Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

[Frediano Ziglio]

> 
> On Mon, Dec 05, 2016 at 09:16:45AM -0500, Frediano Ziglio wrote:
> > > 
> > > On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote:
> > > > On Thu, 2016-12-01 at 11:24 +0000, Frediano Ziglio wrote:
> > > > > This code is the same inside __new_channel but will set the
> > > > > RedsStream from RedChannel.
> > > > 
> > > > Shouldn't this code be removed from __new_channel() then?
> > > 
> > > I agree that this would make things it more obvious what's going on by
> > > looking at the diff. Unless __new_channel is still used for now, and
> > > removing this breaks things.
> > > 
> > > Christophe
> > > 
> > > 
> > 
> > Should I merge into the GObject patch then?
> 
> I don't know, would it make sense to remove the code from
> __new_channel() in this patch, or is this going to break things?
> 
> Christophe
> 

Removing these settings from __new_channel should not break code
but changes timing/delays. If in the future you'll like to do some
test (like git blame) specific to delays could be that you stop at
this commit as causes regressions. Merging on the GObject patch, although
it's a big patch, will avoid the regression and get the diff that looks
as code move instead of one patch that show code add (this) and
the following showing code removal (the GObject one).

Frediano