[Spice-devel] [spice v1] Fix gitignore

[Victor Toso]

Hi,

Sorry, I pushed already.

On Thu, Dec 08, 2016 at 09:15:57AM -0500, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me at victortoso.com>
> > 
> > Signed-off-by: Victor Toso <victortoso at redhat.com>
> > ---
> >  .gitignore              |  4 ++++
> >  server/tests/.gitignore | 37 ++++++++++++++++++++++---------------
> >  tools/.gitignore        |  1 +
> >  3 files changed, 27 insertions(+), 15 deletions(-)
> >  create mode 100644 tools/.gitignore
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 2df7c3f..44eb2b5 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,8 +1,10 @@
> >  *~
> > +*.o
>
> Perhaps can be removed from server/.gitignore.

It could

>
> >  .*.sw?
> >  *.tar.bz2
> >  *.tar.gz
> >  *.pyc
> > +*.html
>
> This "all html" looks a bit strong to me.

Unless we have html templates, I don't see why

>
> >  aclocal.m4
> >  autom4te.cache
> >  compile
> > @@ -35,3 +37,5 @@ docs/manual/manual.chunked/
> >  docs/manual/manual.html
> >  spice-server-enums.h
> >  spice-server-enums.c
>
> OT: perhaps these should be moved to server/.gitignore

It could as well. Although I agree with Pavel that we should have
automatic gitignore generation instead of hand picking these things.

>
> > +.dirstamp
> > +.deps
> > diff --git a/server/tests/.gitignore b/server/tests/.gitignore
> > index 3b4544f..a360297 100644
> > --- a/server/tests/.gitignore
> > +++ b/server/tests/.gitignore
> > @@ -1,17 +1,24 @@
> > -test_display_no_ssl
> > -test_display_streaming
> > -test_empty_success
> > -test_just_sockets_no_ssl
> > -test_fail_on_null_core_interface
> > -test_playback
> > -test_display_resolution_changes
> >  spice-server-replay
> > -test_display_width_stride
> > -test_two_servers
> > -test_vdagent
> > -stat_test
> > -libstat_test1.a
> > -libstat_test2.a
> > -libstat_test3.a
> > -libstat_test4.a
> >  libtest.a
> > +libtest-stat1.a
> > +libtest-stat2.a
> > +libtest-stat3.a
> > +libtest-stat4.a
> > +test-agent-msg-filter
> > +test-codecs-parsing
> > +test-display-no-ssl
> > +test-display-resolution-changes
> > +test-display-streaming
> > +test-display-width-stride
> > +test-empty-success
> > +test-fail-on-null-core-interface
> > +test-just-sockets-no-ssl
> > +test-loop
> > +test-options
> > +test-playback
> > +test-qxl-parsing
> > +test-stat
> > +test-stat-file
> > +test-stream
> > +test-two-servers
> > +test-vdagent
>
> Indeed, I missed these during the rename!
>
> > diff --git a/tools/.gitignore b/tools/.gitignore
> > new file mode 100644
> > index 0000000..96fa383
> > --- /dev/null
> > +++ b/tools/.gitignore
> > @@ -0,0 +1 @@
> > +reds_stat
>
> My fault too!

no problem :)

  toso
>
> Frediano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161208/14b31023/attachment.sig>