[Spice-devel] [PATCH v2 0/2] RHEL7 improvements

[Victor Toso]

Hi,

On Thu, Dec 08, 2016 at 03:43:22PM +0000, Frediano Ziglio wrote:
> These 2 patches attempt to join images split by RHEL7 graphic
> stack (Mesa) decreasing commands handled by spice-server.
>
> You can see the difference between the 2 video:
> - https://www.youtube.com/watch?v=OarV6zUmUdg (before)
> - https://www.youtube.com/watch?v=5fTdCCbFeCg (after)
> These video are realized with some additional changes:
> - the statistics from the terminal have some additional
>   "out_messages" counters. These counters show the messages
>   sent to the client(s). These changes are part of my "stat"
>   branch (partially sent couple of days ago);
> - the replay utility, as you can see, was changed to replay
>   using the real time to allow the video code (which is dependent
>   on timing) to work correctly. The patch is currently not in
>   a good shape (enough to be sent);
> - the client utility was changed to remove the delay due to
>   the lip sync. The glitches (present mostly before these patches)
>   are much reduced.
> 
> Note the number of commands sent to the client reduced from 6097
> to 2016 (current year, just a coincidence).
> The network traffic reduced from 72M to 56M. This is due to the fact
> that having a single stream (as you can see VP8 codec was used) the
> compression on the stream is better.
> 
> These patches fix:
> - https://bugzilla.redhat.com/show_bug.cgi?id=1158029;
> - (probably) https://bugzilla.redhat.com/show_bug.cgi?id=1294564.
>
> Changes since RFC:
> - moved code to DisplayChannel;
> - define a constant for timeout.

As I did some test with streaming today/yesterday I came back to this
and tested in top of [0] - It is super easy to see how much improvement
this is with VP8. Tested on F25 and windows 7 guests.

[0] https://lists.freedesktop.org/archives/spice-devel/2016-December/034526.html

I don't feel knowledgeable enough for a review on this but feel free to
add:

Tested-by: Victor Toso <victortoso at redhat.com>

Cheers,

>
> Future possible optimization: not waiting to join if the joined
> command end at the screen bottom or if the last command contain
> a small image (Mesa split at about 64K pixel, 256Kb).
> 
> Frediano Ziglio (2):
>   display-channel: Join drawables to improve rhel7 behaviour
>   display-channel: Handle timeout for joining drawables
> 
>  server/display-channel-private.h |   6 +-
>  server/display-channel.c         | 191 +++++++++++++++++++++++++++++++-
>  server/red-parse-qxl.h           |   1 +-
>  server/red-worker.c              |  14 +-
>  4 files changed, 205 insertions(+), 7 deletions(-)
> 
> base-commit: 3613ead4d8e25bef796d47c579200c7c1b3c8e2d
> -- 
> git-series 0.9.1
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161214/6a2157b7/attachment.sig>