[Spice-devel] [PATCH spice-protocol, spice-gtk, spice] Inform client about disabled features on server

[Victor Toso]

Hi,

On Tue, Dec 20, 2016 at 08:39:28PM +0100, Pavel Grunt wrote:
> Hello,
>
> this is another attempt to fix the bug about disabled file transfer on
> the server but client allowing to start the file transfer (by drag'n'drop)
> and creating a transfer dialog which cannot be closed:
>  https://bugzilla.redhat.com/show_bug.cgi?id=1373725
>
> Compared to the first attempt, these patches use agent capabilites to
> tell the client that a certain feature is disabled. For that a new capability
> VD_AGENT_CAP_FILE_XFER_DISABLED was introduced. Client then avoids creating
> the transfer dialog and initiating the file transfer.
>
> Thanks,
> Pavel

Just to add that there was some discussion about introducing a
server-guest protocol. If host disables agent features, this kind of
communication would fit perfectly and this would be handled in the agent
instead of server.

Still, quite odd that there was not cap for file-xfer before...

  toso

>
> gits - branch agentfeatures2:
> https://gitlab.com/xerus/spice-protocol
> https://gitlab.com/xerus/spice-gtk
> https://gitlab.com/xerus/spice
> 
> rpms can be downloaded from:
> https://copr.fedorainfracloud.org/coprs/pgrunt/spice-disabled-agent-features/
> 
> spice-protocol
> Pavel Grunt (2):
>   Add support for reporting availability of agent features
>   agent: Add macro for clearing capability
> 
>  spice/vd_agent.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> spice-gtk
> Pavel Grunt (1):
>   main: Handle disabled file transfer
> 
>  configure.ac       |  2 +-
>  src/channel-main.c | 12 ++++++++++++
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> spice server
> Pavel Grunt (2):
>   Filter agent capabilites messages
>   reds: Adjust agent capabilites to disabled features
> 
>  configure.ac                         |  2 +-
>  server/agent-msg-filter.c            |  3 +++
>  server/agent-msg-filter.h            |  1 +
>  server/reds.c                        | 21 +++++++++++++++++++++
>  server/tests/test-agent-msg-filter.c |  8 ++++++--
>  5 files changed, 32 insertions(+), 3 deletions(-)
> 
> -- 
> 2.11.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161221/efdd21af/attachment-0001.sig>