[Spice-devel] please stop send this mail to me

Victor Toso lists at victortoso.com
Tue Feb 2 10:13:21 CET 2016


Hey,

On Tue, Feb 02, 2016 at 09:39:41AM +0800, 牛立新 wrote:
> thanks a lot. 

Feel free to change your preferences in the mailman.
Enter your mail and press the unsubscribe button at
http://lists.freedesktop.org/mailman/options/spice-devel

Cheers,

> 
> 在 2016年2月2日,上午4:00,spice-devel-request at lists.freedesktop.org 写道:
> 
> > Send Spice-devel mailing list submissions to
> > 	spice-devel at lists.freedesktop.org
> > 
> > To subscribe or unsubscribe via the World Wide Web, visit
> > 	http://lists.freedesktop.org/mailman/listinfo/spice-devel
> > or, via email, send a message with subject or body 'help' to
> > 	spice-devel-request at lists.freedesktop.org
> > 
> > You can reach the person managing the list at
> > 	spice-devel-owner at lists.freedesktop.org
> > 
> > When replying, please edit your Subject line so it is more specific
> > than "Re: Contents of Spice-devel digest..."
> > 
> > 
> > Today's Topics:
> > 
> >   1. [spice-server PATCH v1] reds: remove unused structs (Victor Toso)
> >   2. Re: [spice-server PATCH v1] reds: remove unused structs
> >      (Frediano Ziglio)
> >   3. Re: [PATCH 15/18] Move ticketing_enabled to	RedsState	struct
> >      (Frediano Ziglio)
> >   4. Re: [PATCH v2 0/8] Add OpenGL scanout drawing (Marc-André Lureau)
> > 
> > 
> > ----------------------------------------------------------------------
> > 
> > Message: 1
> > Date: Mon,  1 Feb 2016 16:32:23 +0100
> > From: Victor Toso <victortoso at redhat.com>
> > To: spice-devel at lists.freedesktop.org
> > Subject: [Spice-devel] [spice-server PATCH v1] reds: remove unused
> > 	structs
> > Message-ID: <1454340743-12802-1-git-send-email-victortoso at redhat.com>
> > 
> > RedsMigSpiceMessage and RedsMigCertPubKeyInfo
> > ---
> > server/reds.c | 9 ---------
> > 1 file changed, 9 deletions(-)
> > 
> > diff --git a/server/reds.c b/server/reds.c
> > index 9a4ea3e..4b9077c 100644
> > --- a/server/reds.c
> > +++ b/server/reds.c
> > @@ -2807,15 +2807,6 @@ static void set_one_channel_security(int id, uint32_t security)
> > 
> > #define REDS_SAVE_VERSION 1
> > 
> > -typedef struct RedsMigSpiceMessage {
> > -    uint32_t connection_id;
> > -} RedsMigSpiceMessage;
> > -
> > -typedef struct RedsMigCertPubKeyInfo {
> > -    uint16_t type;
> > -    uint32_t len;
> > -} RedsMigCertPubKeyInfo;
> > -
> > static void reds_mig_release(RedsState *reds)
> > {
> >     if (reds->mig_spice) {
> > -- 
> > 2.5.0
> > 
> > 
> > 
> > ------------------------------
> > 
> > Message: 2
> > Date: Mon, 1 Feb 2016 10:42:06 -0500 (EST)
> > From: Frediano Ziglio <fziglio at redhat.com>
> > To: Victor Toso <victortoso at redhat.com>
> > Cc: spice-devel at lists.freedesktop.org
> > Subject: Re: [Spice-devel] [spice-server PATCH v1] reds: remove unused
> > 	structs
> > Message-ID:
> > 	<710008911.19088025.1454341326698.JavaMail.zimbra at redhat.com>
> > Content-Type: text/plain; charset=utf-8
> > 
> >> 
> >> RedsMigSpiceMessage and RedsMigCertPubKeyInfo
> >> ---
> >> server/reds.c | 9 ---------
> >> 1 file changed, 9 deletions(-)
> >> 
> >> diff --git a/server/reds.c b/server/reds.c
> >> index 9a4ea3e..4b9077c 100644
> >> --- a/server/reds.c
> >> +++ b/server/reds.c
> >> @@ -2807,15 +2807,6 @@ static void set_one_channel_security(int id, uint32_t
> >> security)
> >> 
> >> #define REDS_SAVE_VERSION 1
> >> 
> >> -typedef struct RedsMigSpiceMessage {
> >> -    uint32_t connection_id;
> >> -} RedsMigSpiceMessage;
> >> -
> >> -typedef struct RedsMigCertPubKeyInfo {
> >> -    uint16_t type;
> >> -    uint32_t len;
> >> -} RedsMigCertPubKeyInfo;
> >> -
> >> static void reds_mig_release(RedsState *reds)
> >> {
> >>     if (reds->mig_spice) {
> > 
> > Acked-by: Frediano Ziglio <fziglio at redhat.com>
> > 
> > Frediano
> > 
> > 
> > ------------------------------
> > 
> > Message: 3
> > Date: Mon, 1 Feb 2016 10:49:25 -0500 (EST)
> > From: Frediano Ziglio <fziglio at redhat.com>
> > To: spice-devel at lists.freedesktop.org
> > Subject: Re: [Spice-devel] [PATCH 15/18] Move ticketing_enabled to
> > 	RedsState	struct
> > Message-ID:
> > 	<375266288.19090286.1454341765978.JavaMail.zimbra at redhat.com>
> > Content-Type: text/plain; charset=utf-8
> > 
> >> 
> >> From: Jonathon Jongsma <jjongsma at redhat.com>
> >> 
> >> Removing more global variables
> >> ---
> >> server/reds-private.h |  1 +
> >> server/reds.c         | 10 +++++-----
> >> 2 files changed, 6 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/server/reds-private.h b/server/reds-private.h
> >> index 96dfa6a..15cf636 100644
> >> --- a/server/reds-private.h
> >> +++ b/server/reds-private.h
> >> @@ -216,6 +216,7 @@ struct RedsState {
> >>     bool spice_uuid_is_set;
> >>     uint8_t spice_uuid[16];
> >> 
> >> +    int ticketing_enabled;
> >> };
> >> 
> > 
> > Why not using bool and true/false ?
> > 
> >> #endif
> >> diff --git a/server/reds.c b/server/reds.c
> >> index f21e92a..b23ec30 100644
> >> --- a/server/reds.c
> >> +++ b/server/reds.c
> >> @@ -143,7 +143,6 @@ static SpiceCoreInterfaceInternal core_interface_adapter
> >> = {
> >> #define REDS_TOKENS_TO_SEND 5
> >> #define REDS_VDI_PORT_NUM_RECEIVE_BUFFS 5
> >> 
> >> -static int ticketing_enabled = 1; //Ticketing is enabled by default
> >> static pthread_mutex_t *lock_cs;
> >> static long *lock_count;
> >> uint32_t streaming_video = SPICE_STREAM_VIDEO_FILTER;
> >> @@ -1939,7 +1938,7 @@ static void reds_handle_ticket(void *opaque)
> >>     }
> >>     password[password_size] = '\0';
> >> 
> >> -    if (ticketing_enabled && !link->skip_auth) {
> >> +    if (reds->ticketing_enabled && !link->skip_auth) {
> >>         int expired =  reds->taTicket.expiration_time < ltime;
> >> 
> >>         if (strlen(reds->taTicket.password) == 0) {
> >> @@ -2765,7 +2764,7 @@ static void reds_exit(void)
> >> 
> >> static inline void on_activating_ticketing(RedsState *reds)
> >> {
> >> -    if (!ticketing_enabled && reds_main_channel_connected(reds)) {
> >> +    if (!reds->ticketing_enabled && reds_main_channel_connected(reds)) {
> >>         spice_warning("disconnecting");
> >>         reds_disconnect(reds);
> >>     }
> >> @@ -3435,6 +3434,7 @@ SPICE_GNUC_VISIBLE SpiceServer *spice_server_new(void)
> >> #endif
> >>     reds->spice_uuid_is_set = FALSE;
> >>     memset(reds->spice_uuid, 0, sizeof(reds->spice_uuid));
> >> +    reds->ticketing_enabled = TRUE; /* ticketing enabled by default */
> >>     return reds;
> >> }
> >> 
> >> @@ -3555,7 +3555,7 @@ SPICE_GNUC_VISIBLE int
> >> spice_server_set_noauth(SpiceServer *s)
> >> {
> >>     spice_assert(reds == s);
> >>     memset(s->taTicket.password, 0, sizeof(s->taTicket.password));
> >> -    ticketing_enabled = 0;
> >> +    s->ticketing_enabled = 0;
> >>     return 0;
> >> }
> >> 
> >> @@ -3609,7 +3609,7 @@ SPICE_GNUC_VISIBLE int
> >> spice_server_set_ticket(SpiceServer *reds,
> >>     }
> >> 
> >>     on_activating_ticketing(reds);
> >> -    ticketing_enabled = 1;
> >> +    reds->ticketing_enabled = 1;
> >>     if (lifetime == 0) {
> >>         reds->taTicket.expiration_time = INT_MAX;
> >>     } else {
> > 
> > Frediano
> > 
> > 
> > ------------------------------
> > 
> > Message: 4
> > Date: Mon, 1 Feb 2016 17:23:10 +0100
> > From: Marc-André Lureau <marcandre.lureau at gmail.com>
> > To: spice-devel <spice-devel at lists.freedesktop.org>
> > Subject: Re: [Spice-devel] [PATCH v2 0/8] Add OpenGL scanout drawing
> > Message-ID:
> > 	<CAJ+F1C+dSmO7p=b4Qc+nE9jH2VGDnW3c55xaZz2AZVVw30tYow at mail.gmail.com>
> > Content-Type: text/plain; charset=UTF-8
> > 
> > ping
> > 
> > On Mon, Jan 11, 2016 at 1:40 PM, Marc-André Lureau
> > <marcandre.lureau at gmail.com> wrote:
> >> The following series implements the x11 client-side support for
> >> local-only shared OpenGL scanout rendering.
> >> 
> >> The implementation doesn't rely on gtkglarea since:
> >> - it's quite recent (3.16 while rhel7 is currently 3.14)
> >> - using gtkglarea isn't possible without either uncovenient API
> >>  changes (new widget) or ABI break (SpiceDisplay widget to inherit
> >>  from something more flexible than GtkDrawingArea)
> >> - gtkglarea uses various gdk backends to setup GL context, such as
> >>  glx, however dmabuf import requires egl.
> >> 
> >> I have a gtk3/gtkglarea-based branch, which will bring wayland
> >> support. I would suggest to do first a release with gtk2/x11/egl
> >> support before deprecating gtk2 and bumping gtk requirements.
> >> 
> >> v1->v2:
> >> - add some error handling code, fix gl objects leaks
> >> - improve egl code to be compatible with future wayland series
> >> - misc spellings
> >> 
> >> Marc-André Lureau (7):
> >>  gtk: replace configure-event for size-allocate
> >>  Update spice-common
> >>  build-sys: bump to spice-protocol 0.12.11
> >>  Add spice_channel_unix_read_fd()
> >>  build-sys: check for epoxy-egl support
> >>  glib: add local GL scanout support
> >>  gtk: add spice-widget GL scanout support
> >> 
> >> Victor Toso (1):
> >>  channel-main: remove unused header rect.h
> >> 
> >> configure.ac                         |  27 +-
> >> doc/reference/spice-gtk-sections.txt |   1 +
> >> spice-common                         |   2 +-
> >> src/Makefile.am                      |   9 +
> >> src/channel-display.c                | 169 +++++++++-
> >> src/channel-display.h                |  19 ++
> >> src/channel-main.c                   |   1 -
> >> src/map-file                         |   4 +
> >> src/spice-channel-priv.h             |   3 +
> >> src/spice-channel.c                  |  68 +++++
> >> src/spice-glib-sym-file              |   4 +
> >> src/spice-marshal.txt                |   1 +
> >> src/spice-widget-egl.c               | 577 +++++++++++++++++++++++++++++++++++
> >> src/spice-widget-priv.h              |  30 ++
> >> src/spice-widget.c                   | 160 ++++++++--
> >> 15 files changed, 1043 insertions(+), 32 deletions(-)
> >> create mode 100644 src/spice-widget-egl.c
> >> 
> >> --
> >> 2.5.0
> >> 
> > 
> > 
> > 
> > -- 
> > Marc-André Lureau
> > 
> > 
> > ------------------------------
> > 
> > Subject: Digest Footer
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> > 
> > 
> > ------------------------------
> > 
> > End of Spice-devel Digest, Vol 73, Issue 4
> > ******************************************
> 
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list