[Spice-devel] [NSIS] packaging: spec: avoid suffix in iso label

[Christophe Fergeau]

On Tue, Feb 09, 2016 at 03:56:42PM +0200, Yedidyah Bar David wrote:
> On Tue, Feb 9, 2016 at 3:44 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Mon, Feb 08, 2016 at 07:57:42PM +0200, Yedidyah Bar David wrote:
> >> From: Sandro Bonazzola <sbonazzo at redhat.com>
> >>
> >> Avoid suffix in iso labeling: release number with the
> >> full suffix exceeds the maximum length allowed.
> >
> > What does the full suffix look like in your builds?
> 
> For nightly builds it's something like: .20160208121601.gita867579
> 
> > The label in the Makefile is ovirt-wgt-$(DISPLAYED_VERSION)
> > ovirt-wgt- is 10 characters long, which leaves 22 chars for
> > DISPLAYED_VERSION. Is it not enough for whatever version information you
> > need?
> 
> iso images with joliet extensions are limited to 16 chars:
> https://en.wikipedia.org/wiki/Joliet_%28file_system%29

Ah, mkisofs/isoinfo are fine with 32 chars, but Windows truncates at 16
indeed.
Not a big fan of passing N different version numbers from spec file to
Makefile, and potentially to .nsis file, but I'm going to push this with
a mention of the current format in the commit log.

Thanks,

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160209/c2a4d150/attachment.sig>