[Spice-devel] [PATCH v6 06/10] win-usbredir: Introduce use_usbclerk flag

Dmitry Fleytman dmitry at daynix.com
Thu Feb 11 14:03:30 UTC 2016


> On 31 Jan 2016, at 17:50 PM, Dmitry Fleytman <dmitry at daynix.com> wrote:
> 
> 
>> On 30 Jan 2016, at 24:11 AM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
>> 
>> I personally don't think it's very useful to introduce a variable without
>> actually using it anywhere. I'd prefer to combine it with the next commit.
> 
> No problem. I’ll squash.

Squashed.

> 
>> 
>> Reviewed-by: Jonathon Jongsma <jjongsma at redhat.com>
>> 
>> 
>> On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
>>> This flag will be used by future code to distinguish
>>> between WinUsb/UsbDk configuations.
>>> 
>>> Currently this flag is not used and always set to TRUE.
>>> Future code will set its value properly and use it as needed.
>>> 
>>> Signed-off-by: Dmitry Fleytman <dmitry at daynix.com>
>>> ---
>>> src/usb-device-manager.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>> 
>>> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
>>> index 78f038e..55533f9 100644
>>> --- a/src/usb-device-manager.c
>>> +++ b/src/usb-device-manager.c
>>> @@ -123,6 +123,7 @@ struct _SpiceUsbDeviceManagerPrivate {
>>> #ifdef G_OS_WIN32
>>>    SpiceWinUsbDriver     *installer;
>>> #endif
>>> +    gboolean               use_usbclerk;
>>> #endif
>>>    GPtrArray *devices;
>>>    GPtrArray *channels;
>>> @@ -220,6 +221,9 @@ static void
>>> spice_usb_device_manager_init(SpiceUsbDeviceManager *self)
>>>    priv = SPICE_USB_DEVICE_MANAGER_GET_PRIVATE(self);
>>>    self->priv = priv;
>>> 
>>> +#ifdef G_OS_WIN32
>>> +    priv->use_usbclerk = TRUE;
>>> +#endif
>>>    priv->channels = g_ptr_array_new();
>>> #ifdef USE_USBREDIR
>>>    priv->devices  = g_ptr_array_new_with_free_func((GDestroyNotify)
> 



More information about the Spice-devel mailing list