[Spice-devel] [PATCH] memslot: do not crash if guest provide a wrong address

Pavel Grunt pgrunt at redhat.com
Thu Feb 18 10:18:25 UTC 2016


Hi,
please add reference to the bug

On Thu, 2016-02-18 at 09:49 +0000, Frediano Ziglio wrote:
> This could happen with buggy driver.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/memslot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/memslot.c b/server/memslot.c
> index 768762b..99c63e4 100644
> --- a/server/memslot.c
> +++ b/server/memslot.c
> @@ -61,7 +61,7 @@ int memslot_validate_virt(RedMemSlotInfo *info,
> unsigned long virt, int slot_id,
>  
>      if (virt < slot->virt_start_addr || (virt + add_size) > slot-
> >virt_end_addr) {
>          print_memslots(info);
> -        spice_critical("virtual address out of range\n"
> +        spice_warning("virtual address out of range\n"
>                "    virt=0x%lx+0x%x slot_id=%d group_id=%d\n"
>                "    slot=0x%lx-0x%lx delta=0x%lx",
>                virt, add_size, slot_id, group_id,


More information about the Spice-devel mailing list