[Spice-devel] [PATCH v2] server: Fix tests Makefile

Eduardo Lima (Etrunko) etrunko at redhat.com
Thu Jan 7 09:04:28 PST 2016


As reported in https://bugs.freedesktop.org/show_bug.cgi?id=93520, the
build from git is failing in Archlinux systems with undefined
references to glib symbols.

This patch fixes the problem by simply reordering the order libraries
will be linked. Also, removes duplicate $(GLIB_LIBS) variable.

Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
---
 server/tests/Makefile.am | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index 94a4103..fea94ed 100644
--- a/server/tests/Makefile.am
+++ b/server/tests/Makefile.am
@@ -19,7 +19,6 @@ AM_CPPFLAGS += -DAUTOMATED_TESTS
 endif
 
 LDADD =								\
-	$(GLIB2_LIBS)						\
 	$(top_builddir)/spice-common/common/libspice-common.la	\
 	$(top_builddir)/server/libspice-server.la		\
 	$(GLIB2_LIBS)						\
@@ -127,11 +126,11 @@ spice_server_replay_SOURCES = 			\
 
 stat_test_SOURCES = stat-main.c
 stat_test_LDADD = \
-	$(LDADD) \
 	libstat_test1.a \
 	libstat_test2.a \
 	libstat_test3.a \
 	libstat_test4.a \
+	$(LDADD) \
 	$(NULL)
 
 libstat_test1_a_SOURCES = stat-test.c
-- 
2.5.0



More information about the Spice-devel mailing list