[Spice-devel] [spice-protocol] Use gcc builtin rather than asm for memory barriers

Frediano Ziglio fziglio at redhat.com
Thu Jan 7 10:00:04 PST 2016


> 
> This should make things more portable.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=86997
> ---
>  spice/barrier.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/spice/barrier.h b/spice/barrier.h
> index 710da09..7d63721 100644
> --- a/spice/barrier.h
> +++ b/spice/barrier.h
> @@ -34,12 +34,7 @@
>  
>  #ifdef __GNUC__
>  
> -#ifdef __i386__
> -#define spice_mb() __asm__ __volatile__ ("lock; addl $0,0(%%esp)": :
> :"memory")
> -#else
> -//mfence
> -#define spice_mb() __asm__ __volatile__ ("lock; addl $0,0(%%rsp)": :
> :"memory")
> -#endif
> +#define spice_mb() __sync_synchronize ()
>  
>  #else
>  
> --
> 2.5.0

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Compiles under RedHat 6.

Frediano


More information about the Spice-devel mailing list