[Spice-devel] [PATCH 0/4] Add context to SpiceCoreInterface

[Christophe Fergeau]

On Thu, Jan 07, 2016 at 09:07:50PM +0200, Uri Lublin wrote:
> However context was already being passed to core function via the
> opaque parameter.

This 'opaque' parameter is passed by the caller to the
watch_add/timer_add functions, and this is a context which is going to
be used by the SpiceWatchFunc/SpiceTimerFunc callbacks. The mainloop
implementation should not make any assumption about what this 'opaque'
data is, it should just pass it to the appropriate callback.

This was not true for the watch implementation in RedWorker,
worker_watch_add() was assuming the watch callback would be called with
a rcc instance, which imo is very unexpected, and could byte us in the
future.

This series gets rid of this assumption.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20160108/dca6bebd/attachment.sig>