[Spice-devel] [PATCH v3 4/4] worker: use glib main loop

Daniel P. Berrange berrange at redhat.com
Wed Jan 13 04:37:20 PST 2016


On Wed, Jan 13, 2016 at 12:18:45PM +0000, Daniel P. Berrange wrote:
> On Wed, Jan 13, 2016 at 11:39:09AM +0000, Frediano Ziglio wrote:
> > Use the glib mainloop instead of writing our own. The glib loop is both
> > cleaner to use and is more extensible. It is also very mature and
> > reduces the maintenance burden on the spice server.
> 
> Why not take it further and provide the option to do away
> with the spice event loop entirely. Having 2 threads both
> providing event loops (QEMU event loop thread + SPICE event
> loop thread) feels rather pointless. Obviously for backcompat
> you need to be able to run the event loop in SPICE thread,
> but We could provide an API which lets QEMU tell libspice
> that it can use the default GMainContext and not run its
> own.

Ignore this comment. After talking with Marc-Andre I realize that
spice needs its separate event thread because some of the callbacks
take non-negligble wall-clock time to run.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


More information about the Spice-devel mailing list