[Spice-devel] [PATCH 00/15] Backported some patches from refactory branches (14th Jan)

[Frediano Ziglio]

> 
> On Thu, 2016-01-14 at 14:33 +0000, Frediano Ziglio wrote:
> > This patchset restart the integration job.
> > Many new patches try to incrementally remove global reds variable so
> > they add RedsState* as parameter.
> > 
> > Jonathon Jongsma (15):
> >   Don't abort if an item isn't handled.
> >   Make global 'reds' extern
> >   Change reds_register_channel() to take RedsState arg
> >   Change reds_unregister_channel() to take RedsState arg
> >   Change reds_get_mouse_mode() to take RedsState arg
> >   Change reds_set_mouse_mode() to take RedsState arg
> >   Update reds_update_mouse_mode() to take RedsState arg
> >   Change reds_agent_remove() to take RedsState arg
> >   Change reds_find_channel() to take RedsState arg
> >   Change reds_mig_cleanup() to take RedsState arg
> >   Change reds_reset_vdp() to take RedsState arg
> >   Change reds_main_channel_connected() to take RedsState arg
> >   Change reds_client_disconnect() to take RedsState arg
> >   Change reds_disconnect() to take RedsState arg
> >   Change reds_mig_disconnect() to take RedsState arg
> 
> 
> I'd like to make a general comment about these patches. Most of these "change
> <function> to take RedsState arg" commits are fairly small and mechanical. I
> did
> them in small chunks because it made development easier for me. I'm
> interested
> in whether people prefer to keep them in smaller commits like this, or
> whether
> we should combine them into larger commits.
> 
> 

I would prefer the second with the list of functions in the commit message.

Frediano

> 
> > 
> >  server/dcc.c             |   2 +-
> >  server/inputs-channel.c  |  10 ++---
> >  server/main-dispatcher.c |   2 +-
> >  server/red-dispatcher.c  |   4 +-
> >  server/reds-private.h    |   4 +-
> >  server/reds.c            | 106
> >  +++++++++++++++++++++++-----------------------
> > -
> >  server/reds.h            |  11 +++--
> >  server/smartcard.c       |   2 +-
> >  server/sound.c           |   6 +--
> >  server/spicevmc.c        |   4 +-
> >  10 files changed, 77 insertions(+), 74 deletions(-)
> > 
>