[Spice-devel] [spice-gtk PATCH v2] gstaudio: set output parameter to NULL on error

Victor Toso victortoso at redhat.com
Mon Jan 18 06:09:48 PST 2016


This is not really triggered in the current code but this is usually
expected in case of errors; Also, the same function on record side
already does this.
---
 src/spice-gstaudio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/spice-gstaudio.c b/src/spice-gstaudio.c
index 096fea4..2759c2b 100644
--- a/src/spice-gstaudio.c
+++ b/src/spice-gstaudio.c
@@ -600,6 +600,10 @@ static gboolean spice_gstaudio_get_playback_volume_info_finish(SpiceAudio *audio
         G_OBJECT(audio), spice_gstaudio_get_playback_volume_info_async), FALSE);
 
     if (g_simple_async_result_propagate_error(simple, error)) {
+        /* set out args that should have new alloc'ed memory to NULL */
+        if (volume != NULL) {
+            *volume = NULL;
+        }
         return FALSE;
     }
 
-- 
2.5.0



More information about the Spice-devel mailing list