[Spice-devel] [PATCH 15/15] Change reds_mig_started() to take RedsState arg

[Frediano Ziglio]

> 
> On Wed, 2016-01-20 at 13:25 +0000, Frediano Ziglio wrote:
> > From: Jonathon Jongsma <jjongsma at redhat.com>
> > 
> Acked-by: Pavel Grunt <pgrunt at redhat.com>
> > ---
> >  server/reds.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/server/reds.c b/server/reds.c
> > index 67b2071..566d346 100644
> > --- a/server/reds.c
> > +++ b/server/reds.c
> > @@ -2840,7 +2840,7 @@ static void reds_mig_release(RedsState *reds)
> >      }
> >  }
> >  
> > -static void reds_mig_started(void)
> > +static void reds_mig_started(RedsState *reds)
> >  {
> >      spice_info(NULL);
> >      spice_assert(reds->mig_spice);
> > @@ -3901,7 +3901,7 @@ SPICE_GNUC_VISIBLE int
> > spice_server_migrate_connect(SpiceServer *s, const char*
> >      /* main channel will take care of clients that are still during
> > migration (at target)*/
> >      if (main_channel_migrate_connect(reds->main_channel, reds-
> > >mig_spice,
> >                                       try_seamless)) {
> > -        reds_mig_started();
> > +        reds_mig_started(reds);
> >      } else {
> >          if (reds->num_clients == 0) {
> >              reds_mig_release(reds);
> 

Would have sense here to rename the s parameter of this function to reds?

Perhaps to keep the style would be better to use reds instead of s in 12/15.

Frediano