[Spice-devel] [spice-common v4 4/7] tests: Always build tests

Frediano Ziglio fziglio at redhat.com
Thu Jan 21 04:33:11 PST 2016


> 
> The next commit will introduce a test for log messages. As
> libspice-common.la behaviour varies depending on whether
> SPICE_DISABLE_ASSERT was defined at compile-time, this test will also
> take into account this preprocessor define.
> We are more likely to get a consistent build (SPICE_DISABLE_ASSERT being
> the same when building libspice-common.la and the test) if both are
> built at the same time.
> 
> This commit changes that, tests are now built (but not run) at 'make'
> time rather than 'make check' time.

Nack!
This check marshalling code, should have nothing to do with logging.
If has the test should be fixed.

Frediano

> ---
>  tests/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index d612d44..92d2f62 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1,7 +1,7 @@
>  NULL =
>  
>  TESTS = test_marshallers
> -check_PROGRAMS = test_marshallers
> +noinst_PROGRAMS = $(TESTS)
>  test_marshallers_SOURCES =		\
>  	generated_test_marshallers.c	\
>  	generated_test_marshallers.h	\
> --
> 2.5.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list