[Spice-devel] [PATCH v2 0/2] Solve misleading message when the last USB redirection channel is taken

Fabiano Fidêncio fidencio at redhat.com
Thu Jan 21 10:09:04 PST 2016


This series tries to solve the issues reported on rhbz#1298772 in the less
intrusive way possible. As mentioned in the commit log of the second patch
and by Jonathon during the review of v1 this part of code needs some love
and a refactoring task is more than appreciated, but I want to get back to
it later.

Also, Marc-André suggested using a property instead of a new function for
exposing the number of free channels. I took the suggestion and introduced
a new property: UsbDeviceManager::free-channels. It's just a read-only
property as I didn't see the reason why the application using that should
try to set the property (and consequently. no property notify added).

Fabiano Fidêncio (2):
  usb-device-{manager,widget}: Add counter of free channels
  usb-device-{manager,widget}: Remove misleading message when there are
    no channels to redirect

 src/spice-client.h       |  1 +
 src/usb-device-manager.c | 32 +++++++++++++++++++++++++++++++-
 src/usb-device-widget.c  | 43 ++++++++++++++++++++++++++++++++++---------
 3 files changed, 66 insertions(+), 10 deletions(-)

-- 
2.5.0



More information about the Spice-devel mailing list