[Spice-devel] [PATCH] tests: add explanation for test_qxl_pasring_SOURCES

Marc-André Lureau marcandre.lureau at gmail.com
Fri Jan 22 03:36:59 PST 2016


Hi

On Tue, Jan 19, 2016 at 11:41 AM, Frediano Ziglio <fziglio at redhat.com> wrote:
> Instead of using libserver.a to include necessary functions we include
> single files to check for dependencies.
>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/tests/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
> index 8caff04..892a60b 100644
> --- a/server/tests/Makefile.am
> +++ b/server/tests/Makefile.am
> @@ -91,6 +91,8 @@ libstat_test3_a_CPPFLAGS = $(AM_CPPFLAGS) -DTEST_COMPRESS_STAT=1 -DTEST_RED_WORK
>  libstat_test4_a_SOURCES = stat-test.c
>  libstat_test4_a_CPPFLAGS = $(AM_CPPFLAGS) -DTEST_COMPRESS_STAT=1 -DTEST_RED_WORKER_STAT=1 -DTEST_NAME=stat_test4
>
> +# Here we include only needed files to make sure code does not depend
> +# on extra files.
>  test_qxl_parsing_SOURCES =           \

What's the point of doing that?

anyway, if it matters for some reason, I'll drop my cleanup patch.


-- 
Marc-André Lureau


More information about the Spice-devel mailing list