[Spice-devel] [PATCH] small spice_strdup optimization

[Jonathon Jongsma]

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>




On Tue, 2016-01-26 at 16:36 +0000, Frediano Ziglio wrote:
> avoid to compute the string length twice and use memcpy instead of
> strcpy which is faster not having to check for terminator.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  common/mem.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/common/mem.c b/common/mem.c
> index 2fda6f3..e430b5d 100644
> --- a/common/mem.c
> +++ b/common/mem.c
> @@ -46,13 +46,15 @@ size_t spice_strnlen(const char *str, size_t max_len)
>  char *spice_strdup(const char *str)
>  {
>      char *copy;
> +    size_t len;
>  
>      if (str == NULL) {
>          return NULL;
>      }
>  
> -    copy = (char *)spice_malloc(strlen(str) + 1);
> -    strcpy(copy, str);
> +    len = strlen(str) + 1;
> +    copy = (char *)spice_malloc(len);
> +    memcpy(copy, str, len);
>      return copy;
>  }
>