[Spice-devel] [PATCH spice] build-sys: Require glib2 >= 2.36

[Jonathon Jongsma]

On Fri, 2016-01-29 at 16:44 +0100, Pavel Grunt wrote:
> It is needed for g_source_set_ready_time()
> 
> Set GLIB_VERSION_MAX_ALLOWED to avoid using not available functions.
> ---
>  configure.ac | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 2b09ec7..f2f37dd 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -103,8 +103,13 @@ SPICE_PROTOCOL_MIN_VER=0.12.10
>  PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=
> $SPICE_PROTOCOL_MIN_VER])
>  AC_SUBST([SPICE_PROTOCOL_MIN_VER])
>  
> -PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.22])
> -AS_VAR_APPEND([SPICE_REQUIRES], [" glib-2.0 >= 2.22"])
> +GLIB2_MIN_VERSION=2.36
> +GLIB2_REQUIRED_VERSION=GLIB_VERSION_2_36
> +PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= $GLIB2_MIN_VERSION])
> +AC_SUBST(GLIB2_CFLAGS)
> +GLIB2_CFLAGS="$GLIB2_CFLAGS 
> -DGLIB_VERSION_MIN_REQUIRED=$GLIB2_REQUIRED_VERSION"
> +GLIB2_CFLAGS="$GLIB2_CFLAGS 
> -DGLIB_VERSION_MAX_ALLOWED=$GLIB2_REQUIRED_VERSION"
> +AS_VAR_APPEND([SPICE_REQUIRES], [" glib-2.0 >= $GLIB2_MIN_VERSION"])
>  
>  PKG_CHECK_MODULES(PIXMAN, pixman-1 >= 0.17.7)
>  AC_SUBST(PIXMAN_CFLAGS)


As far as I remember, when discussing the newest glib version for virt-viewer,
we decided that 2.38 was the newest one we should require at the moment. So 2.36
should be fine.

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>