[Spice-devel] [PATCH spice-gtk 1/2] spicy: Do not show underscore in label

[Christophe Fergeau]

Hey,

On Thu, Jun 02, 2016 at 03:49:05PM +0200, Pavel Grunt wrote:
> ---
>  src/spicy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/spicy.c b/src/spicy.c
> index 8fc6845..ea4d4e0 100644
> --- a/src/spicy.c
> +++ b/src/spicy.c
> @@ -1518,7 +1518,7 @@ transfer_task_widgets_new(SpiceFileTransferTask *task)
>  
>      widgets->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
>      widgets->hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 6);
> -    widgets->cancel = gtk_button_new_with_label("_Cancel");
> +    widgets->cancel = gtk_button_new_with_label("Cancel");

I know this is an old patch, I'm wondering if this shouldn't be:

diff --git a/src/spicy.c b/src/spicy.c
index ea4d4e0..0598640 100644
--- a/src/spicy.c
+++ b/src/spicy.c
@@ -1518,7 +1518,7 @@ transfer_task_widgets_new(SpiceFileTransferTask *task)

     widgets->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
     widgets->hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 6);
-    widgets->cancel = gtk_button_new_with_label("Cancel");
+    widgets->cancel = gtk_button_new_with_with_mnemonic("_Cancel");

     widgets->progress = gtk_progress_bar_new();
     widgets->label = gtk_label_new(spice_file_transfer_task_get_filename(task));


Not very important as it's in spicy anyway.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160707/42a6168f/attachment-0001.sig>