[Spice-devel] [spice-common 5/5] codegen: Autogenerate client_marshallers.h

Christophe Fergeau cfergeau at redhat.com
Wed Jul 13 15:56:27 UTC 2016


On Wed, Jul 13, 2016 at 12:50:33PM -0300, Eduardo Lima (Etrunko) wrote:
> On 06/23/2016 07:57 AM, Christophe Fergeau wrote:
> > This commit adds autogeneration of a generated_client_marshallers.h
> > header, which is then included in client_marshallers.h
> > 
> > This allows to remove the SpiceMessageMarshallers struct from this file,
> > which has to match what the generated code expects.
> 
> 
> Hi, as spice-common got updated recently, only now I could notice that
> this patch breaks the build out of the tree.
> 
> In file included from
> /home/elima/projects/spice/spice-gtk/src/spice-channel-priv.h:35:0,
>                  from
> /home/elima/projects/spice/spice-gtk/src/spice-audio.c:42:
> /home/elima/projects/spice/spice-gtk/spice-common/common/client_marshallers.h:28:42:
> fatal error: generated_client_marshallers.h: No such file or directory
>  #include "generated_client_marshallers.h"
>                                           ^
> compilation terminated.
> Makefile:1316: recipe for target 'spice-audio.lo' failed
> make[4]: *** [spice-audio.lo] Error 1
> 
> > --- a/common/client_marshallers.h
> > +++ b/common/client_marshallers.h
> > @@ -25,56 +25,12 @@
> >  
> >  #include <spice/protocol.h>
> >  
> > +#include "generated_client_marshallers.h"
> 
> This line should actually be
> 
> +#include "common/generated_client_marshallers.h"


Yes, this looks good, thanks for catching this!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160713/c2c82abc/attachment.sig>


More information about the Spice-devel mailing list