[Spice-devel] [PATCH RFC 09/12] Do not disconnect client if not connected locally in dcc_gl_scanout_item_new

Frediano Ziglio fziglio at redhat.com
Fri Jul 15 13:49:34 UTC 2016


Prepare to support remote connections

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 server/dcc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/server/dcc.c b/server/dcc.c
index d5cfe4c..7fd2fdf 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -567,17 +567,16 @@ static RedSurfaceDestroyItem *red_surface_destroy_item_new(RedChannel *channel,
 
 RedPipeItem *dcc_gl_scanout_item_new(RedChannelClient *rcc, void *data, int num)
 {
-    RedGlScanoutUnixItem *item = spice_new(RedGlScanoutUnixItem, 1);
-    spice_return_val_if_fail(item != NULL, NULL);
-
-    /* FIXME: on !unix peer, start streaming with a video codec */
+    /* no need and not possible to send scanout, upper layer code will do
+     * video streaming */
     if (!reds_stream_is_plain_unix(rcc->stream) ||
         !red_channel_client_test_remote_cap(rcc, SPICE_DISPLAY_CAP_GL_SCANOUT)) {
-        spice_printerr("FIXME: client does not support GL scanout");
-        red_channel_client_disconnect(rcc);
         return NULL;
     }
 
+    RedGlScanoutUnixItem *item = spice_new(RedGlScanoutUnixItem, 1);
+    spice_return_val_if_fail(item != NULL, NULL);
+
     red_pipe_item_init(&item->base, RED_PIPE_ITEM_TYPE_GL_SCANOUT);
 
     return &item->base;
-- 
2.7.4



More information about the Spice-devel mailing list