[Spice-devel] [RFC PATCH vdagent 16/16] Fix return value of update_dev_mode_position

Dmitry Fleytman dmitry at daynix.com
Mon Jul 18 06:34:50 UTC 2016


From: Sameeh Jubran <sameeh at daynix.com>

update_dev_mode_position() should propagate
error of update_mode_position() in case it fails.

Signed-off-by: Sameeh Jubran <sameeh at daynix.com>
Signed-off-by: Dmitry Fleytman <dmitry at daynix.com>
---
 vdagent/display_configuration.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/vdagent/display_configuration.cpp b/vdagent/display_configuration.cpp
index 98b3d82..59dc032 100644
--- a/vdagent/display_configuration.cpp
+++ b/vdagent/display_configuration.cpp
@@ -361,8 +361,7 @@ bool WDDMInterface::update_dev_mode_position(LPCTSTR device_name, DEVMODE* dev_m
     //Convert the position so that the primary is always at (0,0)
     dev_mode->dmPosition.x = x;
     dev_mode->dmPosition.y = y;
-    _ccd.update_mode_position(device_name, dev_mode);
-    return true;
+    return _ccd.update_mode_position(device_name, dev_mode);
 }
 
 bool WDDMInterface::init_d3d_api()
-- 
1.8.3.1



More information about the Spice-devel mailing list