[Spice-devel] [spice-gtk PATCH] spice-widget: init egl only after first gl_scanout

Lukas Venhoda lvenhoda at redhat.com
Fri Jul 22 15:11:30 UTC 2016


On Fri, Jul 22, 2016 at 5:05 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
>
> Why instead of calling it recursively you just move the check
> before?
>
> something like
>
> if (!d->egl.context_ready) {
>    initialize context ...
> }
> if (d->egl.context_ready) {
>    use context (as current code) ...
> }
>
> perhaps would be even better to call spice_egl_init before
> set_egl_enabled
>
> >      }
> >  }
> >
>
> Frediano
>

I wanted to do it like that originally, but didn't want to make a second
runtime if check.

-- 
Lukas Venhoda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160722/d9fa631c/attachment.html>


More information about the Spice-devel mailing list