[Spice-devel] [PATCH spice-common] codegen: Do not generate extra null check

Pavel Grunt pgrunt at redhat.com
Mon Jul 25 16:40:35 UTC 2016


Spotted by coverity
---
 python_modules/demarshal.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/python_modules/demarshal.py b/python_modules/demarshal.py
index 2252f37..de2ccd0 100644
--- a/python_modules/demarshal.py
+++ b/python_modules/demarshal.py
@@ -1098,8 +1098,7 @@ def write_msg_parser(writer, message):
     writer.newline()
     if writer.has_error_check:
         writer.label("error")
-        with writer.block("if (data != NULL)"):
-            writer.statement("free(data)")
+        writer.statement("free(data)")
         writer.statement("return NULL")
     writer.end_block()
 
-- 
2.9.2



More information about the Spice-devel mailing list