[Spice-devel] [server] streaming: Don't start streaming if there is no video encoder

Uri Lublin uril at redhat.com
Wed Jul 27 14:00:47 UTC 2016


On 07/27/2016 12:15 PM, Christophe Fergeau wrote:
> On Mon, Jul 25, 2016 at 06:37:00PM +0200, Francois Gouget wrote:
>> On Sun, 24 Jul 2016, Uri Lublin wrote:
>> [...]
>>> This patch prevents a crash as few lines below there is access
>>> to agent->video_encoder->codec_type.
>>>
>>> I think it would be better to make the check it in
>>> dcc_create_stream(), and replace the patch here to assert.
>>
>> I think it makes more sense to have it this way.
>
> I agree, we could add more checks in dcc_create_stream() if we want

OK.



More information about the Spice-devel mailing list