[Spice-devel] [PATCH spice-gtk] session: Fix IPv6 by using g_network_address_parse

[Victor Toso]

Hi,

Is it worth to include a new unit test to catch this one?

Based on bz comment:
> "Unable to connect to the graphic server spice://[::1]:5900"
> dialog pops up.

> Error reseason is "Error resolving '[::1]': Name or service not known

Cheers,

On Fri, Jul 29, 2016 at 02:19:29PM +0200, Pavel Grunt wrote:
> On Fri, 2016-07-29 at 14:16 +0200, Pavel Grunt wrote:
> > It supports with []
> It supports quoting the address with []
> > 
> > Regression since ea37f06eaa11b6307c797895aeb85d87d142625a
> > 
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1361478
> > ---
> >  src/spice-session.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/spice-session.c b/src/spice-session.c
> > index db283d4..238b5cb 100644
> > --- a/src/spice-session.c
> > +++ b/src/spice-session.c
> > @@ -2116,7 +2116,7 @@ static gboolean open_host_idle_cb(gpointer data)
> >  #endif
> >          } else {
> >              SPICE_DEBUG("open host %s:%d", s->host, open_host->port);
> > -            address = g_network_address_new(s->host, open_host->port);
> > +            address = g_network_address_parse(s->host, open_host->port,
> > &open_host->error);
> >          }
> >  
> >          if (address == NULL || open_host->error != NULL) {
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel