[Spice-devel] [PATCH spice-gtk v5 0/6] Allow ipv6 proxy url

[Victor Toso]

Hi,

On Wed, Jun 01, 2016 at 10:04:43AM +0200, Pavel Grunt wrote:
> Hi,
>
> these patches add ipv6 support to SpiceUri, so it can be used in SPICE_PROXY.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335239

Series looks good, thanks!
Acked-by: Victor Toso <victortoso at redhat.com>

>
> v5 per Victor's review:
>  - renamed tests/test-spice-uri.c to tests/uri.c (binary name is test-spice-uri)
>  - helper function for tests are introduced in the first patch, so adding ipv6
>    tests does not change too many lines and the patch is easier to read
> 
> v4 contains changes suggested by Christophe, Victor, Frediano:
>  - Added check for scheme
>  - Tests check for error messages
>  - Port 0 is considered invalid
>  - Fixed memory leaks
> 
> v3 per Frediano's review:
>  - Added test for port out of range (0, 65535)
>  - reset all values of SpiceUri before parsing
> 
> v2 contains changes suggested by Frediano and Victor:
>  - more tests (missing port, missing ending bracket)
>  - tests are defined in array, so it is easier to add new test cases
>  - follow ipv6 address format http://user:password@[ipv6]:port
> 
> Thanks,
> 
> Pavel Grunt (6):
>   tests: Add test for SpiceURI
>   spice-uri: Reset SpiceURI before parsing
>   spice-uri: Do not allow empty port string
>   spice-uri: Check if port is in allowed range
>   spice-uri: Validate uri scheme
>   spice-uri: Add ipv6 support
> 
>  src/spice-uri.c   |  76 +++++++++++++++++++++--------
>  tests/Makefile.am |   2 +
>  tests/uri.c       | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 202 insertions(+), 19 deletions(-)
>  create mode 100644 tests/uri.c
> 
> -- 
> 2.8.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel