[Spice-devel] [PATCH] smartcard: Avoid crash on remove_interface call

Frediano Ziglio fziglio at redhat.com
Wed Jun 1 12:40:05 UTC 2016


SpiceCharDeviceInstance is not a GObject, the GObject is char_device->st
as the above line is stating.
The crash never happen as Qemu never calls spice_server_remove_interface
for smartcards.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 server/smartcard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/smartcard.c b/server/smartcard.c
index 7a34080..872aa1d 100644
--- a/server/smartcard.c
+++ b/server/smartcard.c
@@ -274,7 +274,7 @@ void smartcard_device_disconnect(SpiceCharDeviceInstance *char_device)
 {
     g_return_if_fail(RED_IS_CHAR_DEVICE_SMARTCARD(char_device->st));
 
-    g_object_unref(char_device);
+    g_object_unref(char_device->st);
 }
 
 RedCharDevice *smartcard_device_connect(RedsState *reds, SpiceCharDeviceInstance *char_device)
-- 
2.7.4



More information about the Spice-devel mailing list