[Spice-devel] [PATCH spice-gtk 2/2] widget: Use GDK_GRAB_FAILED with Gtk >= 3.16

[Eduardo Lima (Etrunko)]

On 06/02/2016 10:59 AM, Eduardo Lima (Etrunko) wrote:
> On 06/02/2016 10:49 AM, Pavel Grunt wrote:
>> Although is not mentioned in Gtk docs, the value was defined in 3.16.
>>
>> Reported-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>> ---
>>  src/spice-widget.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/spice-widget.c b/src/spice-widget.c
>> index d0fa912..8998daf 100644
>> --- a/src/spice-widget.c
>> +++ b/src/spice-widget.c
>> @@ -934,6 +934,9 @@ static GdkGrabStatus do_pointer_grab(SpiceDisplay *display)
>>  {
>>      SpiceDisplayPrivate *d = display->priv;
>>      GdkWindow *window = GDK_WINDOW(gtk_widget_get_window(GTK_WIDGET(display)));
>> +#if !GTK_CHECK_VERSION(3,16,0)
>> +#define GDK_GRAB_FAILED 5
>> +#endif
>>      GdkGrabStatus status = GDK_GRAB_FAILED;
>>      GdkCursor *blank = get_blank_cursor();
>>  
>>
> Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> 


Thinking better about it, maybe you should define this in a separate
compat file to avoid being forgotten in the middle of the code for ever.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com