[Spice-devel] [PATCH 2/4] worker: Record cursor commands

Frediano Ziglio fziglio at redhat.com
Mon Jun 6 08:21:48 UTC 2016


> 
> On Fri, 2016-06-03 at 10:59 +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/red-worker.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/server/red-worker.c b/server/red-worker.c
> > index a14f55d..e754bd2 100644
> > --- a/server/red-worker.c
> > +++ b/server/red-worker.c
> > @@ -156,6 +156,11 @@ static int red_process_cursor(RedWorker *worker, int
> > *ring_is_empty)
> >              worker->cursor_poll_tries++;
> >              return n;
> >          }
> > +
> > +        if (worker->record)
> > +            red_record_qxl_command(worker->record, &worker->mem_slots,
> > ext_cmd,
> > +                                   stat_now(CLOCK_MONOTONIC));
> > +
> 
> consider using spice_get_monotonic_time_ns() instead?
> 

This is symmetric to the code in red_process_display.
Should not be red_get_monotonic_time_ns() ?

> >          worker->cursor_poll_tries = 0;
> >          switch (ext_cmd.cmd.type) {
> >          case QXL_CMD_CURSOR: {
> 
> 
> Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
> 
> 

Frediano


More information about the Spice-devel mailing list