[Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

[Christophe Fergeau]

Hey,

On Mon, Jun 13, 2016 at 07:09:29PM +0200, Marc-André Lureau wrote:
> >> On Thu, Jun 18, 2015 at 07:14:13PM -0400, sstutsma at redhat.com wrote:
> >> > From: Sandy Stutsman <sstutsma at redhat.com>
> >> >
> >> > Each monitor on a Windows guest is represented as a separate, single-headed
> >> > device with its own framebuffer.  When there are multiple monitors, all
> >> > monitors but one will have a non-zero xy config position.  But even in
> >> > these cases the whole area (frame-buffer) of each monitor should be
> >> > updated.
> >> >
> >> > Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419


> 
> That's not compatible with virgl, which may use a monitor scanout
> different than +0+0 (in multimonitor for ex, but one monitor per
> display channel).
> 
> I could probably workaround the issue with an extra test such as if
> (monitors->len == 1 && !d->egl.enabled)... But that condition looks
> wrong to me anyway.
> 
> My understanding is that there is some confusing between monitor
> configuration position (the monitor config on main channel), and the
> scanout/primary position (the monitor config on display channel).

To be honest, I'm not sure about the difference between these... Is this
documented anywhere?
If you mean that the main channel monitor configuration message should
describe the overall monitor layout (including the (x, y) position) of
all monitors across all display channels, and then the display channel
monitor configuration message only describes the offset of the
monitor(s) within the scanout of the current display channel, then yes,
the agent changes corresponding to that patch were probably wrong.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160614/3d61db86/attachment.sig>