[Spice-devel] [PATCH 2/5] Destroy pthread structures

Jonathon Jongsma jjongsma at redhat.com
Fri Jun 17 19:23:26 UTC 2016


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>


On Fri, 2016-06-17 at 14:58 +0100, Frediano Ziglio wrote:
> Current Linux pthread implementation should use futex so there should
> be no leak but calling destroy avoid possible future leaks.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/image-encoders.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/server/image-encoders.c b/server/image-encoders.c
> index b47ae35..43cabfe 100644
> --- a/server/image-encoders.c
> +++ b/server/image-encoders.c
> @@ -488,6 +488,7 @@ void image_encoders_free(ImageEncoders *enc)
>  #endif
>      zlib_encoder_destroy(enc->zlib);
>      enc->zlib = NULL;
> +    pthread_mutex_destroy(&enc->glz_drawables_inst_to_free_lock);
>  }
>  
>  /* Remove from the to_free list and the instances_list.
> @@ -820,6 +821,7 @@ static void image_encoders_release_glz(ImageEncoders *enc)
>      ring_remove(&shared_dict->base);
>      pthread_mutex_unlock(&glz_dictionary_list_lock);
>      glz_enc_dictionary_destroy(shared_dict->dict, &enc->glz_data.usr);
> +    pthread_rwlock_destroy(&shared_dict->encode_lock);
>      free(shared_dict);
>  }
>  


More information about the Spice-devel mailing list