[Spice-devel] [PATCH 1/3] add a check for negate cases on enumerations

[Christophe Fergeau]

On Tue, Jun 21, 2016 at 10:26:58AM +0100, Frediano Ziglio wrote:
> Not supported by code so trigger an error to avoid invalid usages

There are probably a lot of such cases which are not properly caught
fwiw, but why not for this one.


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  python_modules/ptypes.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
> index 74f3e55..1f4e068 100644
> --- a/python_modules/ptypes.py
> +++ b/python_modules/ptypes.py
> @@ -686,6 +686,7 @@ class SwitchCase:
>              if v == None:
>                  return "1"
>              elif var_type.is_enum():
> +                assert v[0] == "", "Negation of enumeration in switch is not supported"
>                  checks.append("%s == %s" % (var_cname, var_type.c_enumname_by_name(v[1])))
>              else:
>                  checks.append("%s(%s & %s)" % (v[0], var_cname, var_type.c_enumname_by_name(v[1])))
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160621/7621f709/attachment.sig>