[Spice-devel] [NSIS 5/5] ovirt: Add ovirt-guest-agent service removal

[Christophe Fergeau]

On Tue, Jun 21, 2016 at 07:35:14PM +0200, Vinzenz Feenstra wrote:
> 
> > On Jun 21, 2016, at 5:11 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > 
> > On Tue, Jun 21, 2016 at 05:26:33PM +0300, Yedidyah Bar David wrote:
> >> From: Vinzenz Feenstra <vfeenstr at redhat.com>
> >> 
> >> Previously the ovirt guest agent service registration has not been
> >> removed during the uninstallation.
> >> This patch adds the removal code.
> > 
> > Isn't this supposed to be handled by un.StopServices?
> > It has:
> > 
> > !ifdef OVIRT
> >  push "OVirtGuestService"
> >  Call ${un}StopService
> > !endif
> > 
> > 
> > Christophe
> 
> Thats stopping them, but not uninstalling (removing)

Ah right. The vdagent and balloon service would have the same issue
then, don't they? If yes, we could have a generic UninstallService
used for these various services.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160622/fd0045a7/attachment.sig>