[Spice-devel] [spice-common 3/5] codegen: Use "" rather than <> for cmdline includes

Pavel Grunt pgrunt at redhat.com
Thu Jun 23 12:03:45 UTC 2016


Hi Christophe,

they were patches changing spice common includes to use <> instead of "", so I
would keep it.

Pavel

On Thu, 2016-06-23 at 12:57 +0200, Christophe Fergeau wrote:
> Includes specified on the command line are currently #included with <>
> rather than "". However, they are usually spice-common headers, so it
> makes more sense to include them using ""
> ---
>  spice_codegen.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/spice_codegen.py b/spice_codegen.py
> index 53c7be3..410acbd 100755
> --- a/spice_codegen.py
> +++ b/spice_codegen.py
> @@ -211,8 +211,8 @@ if options.print_error:
>  
>  if options.includes:
>      for i in options.includes:
> -        writer.header.writeln('#include <%s>' % i)
> -        writer.writeln('#include <%s>' % i)
> +        writer.header.writeln('#include "%s"' % i)
> +        writer.writeln('#include "%s"' % i)
>  
>  if options.generate_enums or options.generate_dissector:
>      write_enums(writer, options.generate_dissector)


More information about the Spice-devel mailing list