[Spice-devel] [spice-common 3/5] codegen: Use "" rather than <> for cmdline includes

Pavel Grunt pgrunt at redhat.com
Thu Jun 23 12:33:39 UTC 2016


On Thu, 2016-06-23 at 14:25 +0200, Christophe Fergeau wrote:
> On Thu, Jun 23, 2016 at 02:03:45PM +0200, Pavel Grunt wrote:
> > Hi Christophe,
> > 
> > they were patches changing spice common includes to use <> instead of "", so
> > I
> > would keep it.
> 
> The generated code is in spice-common/common, so my understanding is
> that "" should be used there for headers from the spice-common module
> (see spice-common/common/region.c for example). Headers from other
> modules (spice-protocol) should use <>.
> In this case, it's changing #include <common/...> to #include
> "common/..." (but it would do the wrong thing if we started passing
> spice-protocol headers on the command line)
> 
Right, thanks for the explanation, ack

Pavel



More information about the Spice-devel mailing list