[Spice-devel] [PATCH 3/3] make allocation fixed instead of variable

Frediano Ziglio fziglio at redhat.com
Wed Mar 2 15:09:53 UTC 2016


> 
> On Tue, Feb 23, 2016 at 01:57:59PM -0600, Jonathon Jongsma wrote:
> > 
> > I'm a bit ambivalent about this change. Although it may generate better
> > code, I
> > think that it makes the code slightly more difficult to read. I'd almost
> > prefer
> > a #define to the enum solution. But I guess I don't care too much.
> 
> I definitely prefer a #define to the enum solution. But do we care at
> all about making these array sizes known at compile-time? Do we get any
> benefit from it?
> 
> Christophe
> 

I already discarded the patch.
Turned out that the missing optimization was due to a -O0 on my side.
I was trying to remove global variable (not const) from code and this
mis-optimization cause a variable to be added.
I updated my script to ignore these variables.

Frediano


More information about the Spice-devel mailing list