[Spice-devel] [PATCH libcacard 2/2] vscclient: help scan-build

Marc-André Lureau marcandre.lureau at gmail.com
Thu Mar 3 00:58:17 UTC 2016


scan-build gives a false-positive error because it gets confused that
optarg may be NULL. Help him by adding an assert.

Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
Reported-by: Miroslav Rezanina <mrezanin at redhat.com>
---
 src/vscclient.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/vscclient.c b/src/vscclient.c
index dd20842..0954b3f 100644
--- a/src/vscclient.c
+++ b/src/vscclient.c
@@ -679,6 +679,8 @@ main(
 #endif
 
     while ((c = getopt(argc, argv, "c:e:d:")) != -1) {
+        assert(optarg != NULL);
+
         switch (c) {
         case 'c':
             if (cert_count >= MAX_CERTS) {
-- 
2.5.0



More information about the Spice-devel mailing list