[Spice-devel] [spice v10 04/27] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

[Christophe Fergeau]

On Wed, Mar 02, 2016 at 07:46:26PM +0100, Francois Gouget wrote:
> On Wed, 2 Mar 2016, Christophe Fergeau wrote:
> [...]
> > > +if test "x$enable_gstreamer" != "xno"; then
> > > +    SPICE_CHECK_GSTREAMER(GSTREAMER_1_0, 1.0, [gstreamer-1.0 gstreamer-base-1.0 gstreamer-app-1.0 gstreamer-video-1.0],
> > > +        [enable_gstreamer="yes"
> > > +         SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-base 1.0], [appsrc videoconvert appsink])
> > > +         SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gstreamer-libav 1.0], [avenc_mjpeg])
> > > +         SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-good 1.0], [vp8enc])
> > > +         SPICE_CHECK_GSTREAMER_ELEMENTS($GST_INSPECT_1_0, [gst-plugins-ugly 1.0], [x264enc])
> > 
> > Maybe the addition of the tests for vp8enc/x264enc should be moved to
> > the respective commits making use of these?
> 
> Whoops, I missed those. Moved.
> 
> 
> > However, I don't think we can go with these compile-time tests and
> > disable gstreamer altogether when they are missing.
> 
> SPICE_CHECK_GSTREAMER_ELEMENTS() only issues warnings.

Ah right, forgot that, great then :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160303/6b84146d/attachment-0001.sig>